Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 820 release #856

Merged
merged 9 commits into from
Feb 26, 2020
Merged

Issue 820 release #856

merged 9 commits into from
Feb 26, 2020

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Feb 25, 2020

Description

Admin changes for the v0.2.0 release. Default branch will be changed to develop after this release.

Fixes #820

@valentinsulzer valentinsulzer changed the base branch from master to issue-613-citing February 25, 2020 19:15
@valentinsulzer valentinsulzer changed the base branch from issue-613-citing to master February 25, 2020 22:02
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #856 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #856   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         209      209           
  Lines       10587    10588    +1     
=======================================
+ Hits        10342    10343    +1     
  Misses        245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf5990...109f395. Read the comment docs.

@tlestang
Copy link
Contributor

Do you get why Travis fails on Mac?
integration.test_models.test_full_battery_models.test_lithium_ion.test_dfn.TestDFN seems to cause the issue.. but no issue on other platforms.

@valentinsulzer
Copy link
Member Author

I think (but not sure yet) this could be because I updated the scikit-fem version to 0.4.0, it still works but much slower for some reason - so the test times out. We only use scikit-fem for the 2+1D models at the moment

@valentinsulzer
Copy link
Member Author

Didn't make any difference locally but trying to revert and see if that works better

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer

@valentinsulzer valentinsulzer merged commit 801492b into master Feb 26, 2020
@valentinsulzer valentinsulzer deleted the issue-820-release branch February 26, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.2.0 release
4 participants