Issue 812 teval units

[valentinsulzer]

Description

Make time for solver dimensional (seconds)

Fixes #812

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #832 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   98.18%   98.24%   +0.06%     
==========================================
  Files         180      180              
  Lines       10245    10254       +9     
==========================================
+ Hits        10059    10074      +15     
+ Misses        186      180       -6

Impacted Files	Coverage Δ
pybamm/quick_plot.py	98.86% <100%> (+2.31%)	⬆️
pybamm/simulation.py	94.3% <100%> (+1%)	⬆️
pybamm/solvers/base_solver.py	99.39% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7afcf...cc12680. Read the comment docs.

[brosaplanella]

Looks good to me. Just a quick question: is now sol.t in seconds or is it dimensionless?

[valentinsulzer]

Thanks - sol.t is still dimensionless ( I had made it dimensional but the others pointed out dimensionless is more consistent with sol.y)