Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 695 export variables #811

Merged
merged 6 commits into from
Feb 11, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Add some more ways to export variables (matlab and csv file), to then post-process using different tools.

Fixes #695

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer changed the base branch from master to issue-658-experiment February 7, 2020 22:57
@valentinsulzer valentinsulzer changed the base branch from issue-658-experiment to master February 10, 2020 23:58
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #811 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #811   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         181      181           
  Lines       10227    10243   +16     
=======================================
+ Hits        10042    10058   +16     
  Misses        185      185           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f8268...9c99f00. Read the comment docs.

Copy link
Contributor

@Scottmar93 Scottmar93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great!!

@valentinsulzer valentinsulzer merged commit d22b0d1 into master Feb 11, 2020
@valentinsulzer valentinsulzer deleted the issue-695-export-variables branch February 11, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve interface for post-processed variables, including exporting
2 participants