#782 add harmonic mean #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
+ Coverage 98.44% 98.45% +<.01%
==========================================
Files 179 179
Lines 9896 9945 +49
==========================================
+ Hits 9742 9791 +49
Misses 154 154
Continue to review full report at Codecov.
|
valentinsulzer
approved these changes
Jan 13, 2020
| \\beta = \\frac{\\Delta x_1}{\\Delta x_2 + \\Delta x_1} | ||
|
|
||
| accounts for the difference in the control volume widths. This is the | ||
| definiton from [1]. |
There was a problem hiding this comment.
is this the same definition as the Recktenwald paper?
There was a problem hiding this comment.
yeah, just in slightly different notation. Could remove this ref if you think it's cleaner to just provide one
There was a problem hiding this comment.
just saying it's the same but with different notation would be fine (you can add that commit with [ci skip] if you don't want to wait for the tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the harmonic mean to the finite element method. This is then used in
process_binary_operatorsso that fluxes are computed using the harmonic mean of the diffusivity (or conductivity etc.)Fixes #782
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: