Issue 743 input node #752
Merged
Issue 743 input node #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 98.35% 98.38% +0.03%
==========================================
Files 175 176 +1
Lines 9609 9678 +69
==========================================
+ Hits 9451 9522 +71
+ Misses 158 156 -2
Continue to review full report at Codecov.
|
rtimms
approved these changes
Dec 5, 2019
pybamm/simulation.py
Outdated
| @@ -185,7 +187,8 @@ def solve(self, t_eval=None, solver=None, check_model=True): | |||
| if solver is None: | |||
| solver = self.solver | |||
|
|
|||
| self._solution = solver.solve(self.built_model, t_eval) | |||
| self.t_eval = t_eval | |||
| self._solution = solver.solve(self.built_model, t_eval, inputs=inputs) | |||
|
|
|||
| def step(self, dt, solver=None, external_variables=None, save=True): | |||
There was a problem hiding this comment.
do we want to be able to pass inputs to step as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add InputParameter node that will be useful for parameter estimation
Fixes #743
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: