-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulation save and load #732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 98.18% 98.27% +0.09%
==========================================
Files 175 175
Lines 9288 9350 +62
==========================================
+ Hits 9119 9189 +70
+ Misses 169 161 -8
Continue to review full report at Codecov.
|
at some point the generated python code is just a plain string, I would pickle that instead. You would have to ensure that when you load the pickled object that the string is then converted to python bytecode again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great thanks @tinosulzer
Given that the default setup is now casadi I will leave this up to a new issue |
Description
Sort out all pickle issues and add very basic save / load functionality.
Generated python code cannot be pickled so raises error (@martinjrobins any ideas for a way round this?)
Note this branch currently has changes from 731 but 731 is ready be merged to master
Fixes #730
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: