-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 699 remove autograd #723
Conversation
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 98.1% 98.13% +0.03%
==========================================
Files 175 172 -3
Lines 9196 9188 -8
==========================================
- Hits 9022 9017 -5
+ Misses 174 171 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all much cleaner, thanks @tinosulzer !
function_name.parameters_eval[param] = new_sym.evaluate() | ||
|
||
# Create Function or Interpolant objec | ||
# Create Function or Interpolant or Scalar objec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: object
CHANGELOG.md
Outdated
@@ -22,6 +24,7 @@ | |||
|
|||
## Bug fixes | |||
|
|||
- Improved flexibility of parameter values so that parameters can be set as functions or scalars ([#723](https://github.com/pybamm-team/PyBaMM/pull/723)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work for things like diffusivity which we assume is a function of some of the variables, or just functions of time/parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work with both. If something is assumed to be a function in the model then we can pass a scalar and it will always take that scalar value without changing the model. But the other way round (scalar to function) doesn't (can't) work, as you have to tell the model what the function depends on
…BaMM into issue-699-remove-autograd
Description
Remove autograd dependency. Also had to reformat the current functions and introduce a Heaviside symbol.
Fixes #699
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: