-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 697 abs tol vec #700
Conversation
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=========================================
- Coverage 98.26% 98.17% -0.1%
=========================================
Files 176 176
Lines 9106 9133 +27
=========================================
+ Hits 8948 8966 +18
- Misses 158 167 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers @Scottmar93 , looks good, other than the coverage 😉
slices = state_vec.y_slices[0] | ||
self._atol[slices] = tol | ||
|
||
def _check_atol_type(self, size): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it clear in the name that this function also changes self._atol. In fact this could all go in @atol.setter
, either for KLU or BaseSolver
Description
Added setting tols by variable to the KLU solver.
Fixes #697
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: