-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 570 processed var warning #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great thanks @tinosulzer !
@@ -12,7 +17,5 @@ | |||
|
|||
# Create a custom logger | |||
logger = logging.getLogger(__name__) | |||
set_logging_level("WARNING") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the test_logger
test needs updating as the default logger level has changed
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 98.56% 98.56% +<.01%
==========================================
Files 170 170
Lines 8517 8521 +4
==========================================
+ Hits 8395 8399 +4
Misses 122 122
Continue to review full report at Codecov.
|
Description
Add warning if processed variable is called outside range
Fixes #570
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: