-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 623 soc enhancement #627
Conversation
…ssue-623-soc_enhancement
…issue-623-soc_enhancement rts
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 98.48% 98.48% -0.01%
==========================================
Files 169 167 -2
Lines 8204 8172 -32
==========================================
- Hits 8080 8048 -32
Misses 124 124
Continue to review full report at Codecov.
|
…ssue-623-soc_enhancement
…issue-623-soc_enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me, thanks @TomTranter ! just a couple of minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too :)
@rtimms @tinosulzer I made the example script a bit longer. You may want to put this in results instead? It's good to go otherwise |
Description
Calculate SOC.
Introduce r_average operator
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: