Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 623 soc enhancement #627

Merged
merged 18 commits into from
Oct 3, 2019
Merged

Issue 623 soc enhancement #627

merged 18 commits into from
Oct 3, 2019

Conversation

TomTranter
Copy link
Contributor

@TomTranter TomTranter commented Sep 19, 2019

Description

Calculate SOC.
Introduce r_average operator

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #627 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   98.48%   98.48%   -0.01%     
==========================================
  Files         169      167       -2     
  Lines        8204     8172      -32     
==========================================
- Hits         8080     8048      -32     
  Misses        124      124
Impacted Files Coverage Δ
...bmodels/particle/fickian/fickian_many_particles.py 100% <ø> (ø) ⬆️
pybamm/solvers/base_solver.py 98.48% <ø> (+1.71%) ⬆️
pybamm/expression_tree/unary_operators.py 96.18% <100%> (+0.1%) ⬆️
pybamm/models/submodels/particle/base_particle.py 97.29% <100%> (+0.42%) ⬆️
pybamm/expression_tree/evaluate.py 95.74% <0%> (-1.07%) ⬇️
pybamm/discretisations/discretisation.py 100% <0%> (ø) ⬆️
...m/models/full_battery_models/base_battery_model.py 99.57% <0%> (ø) ⬆️
pybamm/expression_tree/symbol.py 97.58% <0%> (ø) ⬆️
pybamm/models/reaction_diffusion.py
pybamm/models/simple_ode_model.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbc419...9a9aace. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, thanks @TomTranter ! just a couple of minor comments

examples/scripts/SPMe_SOC.py Show resolved Hide resolved
pybamm/models/submodels/particle/base_particle.py Outdated Show resolved Hide resolved
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too :)

@TomTranter
Copy link
Contributor Author

@rtimms @tinosulzer I made the example script a bit longer. You may want to put this in results instead? It's good to go otherwise

@TomTranter TomTranter merged commit 8afc8f9 into master Oct 3, 2019
@valentinsulzer valentinsulzer deleted the issue-623-soc_enhancement branch October 8, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants