Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometric input params #4665

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

test mesh

037d4b4
Select commit
Loading
Failed to load commit list.
Draft

Geometric input params #4665

test mesh
037d4b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 21, 2024 in 0s

99.06% (-0.16%) compared to a7253b8

View this Pull Request on Codecov

99.06% (-0.16%) compared to a7253b8

Details

Codecov Report

Attention: Patch coverage is 71.75573% with 37 lines in your changes missing coverage. Please review.

Project coverage is 99.06%. Comparing base (a7253b8) to head (037d4b4).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/spatial_methods/finite_volume.py 65.85% 28 Missing ⚠️
src/pybamm/meshes/meshes.py 68.96% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4665      +/-   ##
===========================================
- Coverage    99.22%   99.06%   -0.16%     
===========================================
  Files          303      303              
  Lines        23070    23195     +125     
===========================================
+ Hits         22891    22979      +88     
- Misses         179      216      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.