Removing the macos-12 runner

[kratman]

Description

The macos-12 runner is being deprecated in December. This switches to the macos-13 runner

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (fb81f21) to head (717dd7c).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4520   +/-   ##
========================================
  Coverage    99.42%   99.42%           
========================================
  Files          299      299           
  Lines        22715    22715           
========================================
  Hits         22584    22584           
  Misses         131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kratman]

Converting to a draft while I take a look at the failure. It does appear to be repeatable

[agriyakhetarpal]

It looks like it's coming from the MLIR stuff, since Python 3.11 on macOS is the only Python version where it's enabled

[kratman]

It looks like it's coming from the MLIR stuff, since Python 3.11 on macOS is the only Python version where it's enabled

Yeah it looks like it would not have been attempted in the old one with macos-12:

            if (not sys.version_info[:2] == (3, 11)) or mac_ver < 13:
                warnings.warn(
                    (
                        "IREE is only supported on MacOS 13 (or higher) and Python"
                        "version 3.11. Setting PYBAMM_IDAKLU_EXPR_IREE=OFF."
                    ),
                    stacklevel=2,
                )
                return "OFF"

[kratman]

@agriyakhetarpal The version of IREE used before was a nightly build not a stable build, so I will try using the stable one instead

[kratman]

Temporary fix to make this work. I will create an issue for it

[kratman]

@agriyakhetarpal Let me know if this temporary fix is acceptable. I created this issue for solving the MacOS-13 issue #4521

[agriyakhetarpal]

Yes, I think we can't do much about this, so this is acceptable for me

[agriyakhetarpal]

Ah, I didn't realise my review was dismissed. I'm personally not a fan of this setting (we experimented with it and later removed it in the pybamm-cookie repo), since the "Require conversation resolution before merging" option worked well.

[kratman]

Ah, I didn't realise my review was dismissed. I'm personally not a fan of this setting (we experimented with it and later removed it in the pybamm-cookie repo), since the "Require conversation resolution before merging" option worked well.

Except I have seen a bunch of PRs get merged with real changes that never got reviewed due to the lack of having this setting. It is a necessary setting for a good project

[agriyakhetarpal]

Sure, let's keep this in that case, then!