Add _from_json functionality for pybamm.sign #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4517 +/- ##
========================================
Coverage 99.42% 99.42%
========================================
Files 299 299
Lines 22691 22715 +24
========================================
+ Hits 22560 22584 +24
Misses 131 131 ☔ View full report in Codecov by Sentry. |
pipliggins
requested review from
martinjrobins,
rtimms and
valentinsulzer
as code owners
pkalbhor
pushed a commit
to pkalbhor/PyBaMM
that referenced
this pull request
Nov 15, 2024
* Add _from_json functionality for Sign + test * Update changelog --------- Co-authored-by: Eric G. Kratz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_from_jsoninpybamm.Signwas previously labelled as NotImplemented; #4394 identified this as a mistake as thepybamm.Signclass should be able to be de/serialised. This PR adds that functionality in.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: