More accurate QuickPlots with Hermite interpolation

[MarcBerliner]

Description

The QuickPlot class plots the results using the raw data points. With the new Hermite interpolation changes in the IDAKLUSolver, we can improve the visual appearance of plots by interpolating the data. This PR adds 100 evenly spaced interpolation time points for all sub-solutions.

For example,

import pybamm

model = pybamm.lithium_ion.SPM()
solver = pybamm.IDAKLUSolver()
sim = pybamm.Simulation(model, solver=solver)
sol = sim.solve([0, 3600])

sol.plot(output_variables=["Voltage [V]"])

Hermite interpolation (new)

Raw data (old)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (e4eb82a) to head (bb737aa).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4483      +/-   ##
===========================================
- Coverage    99.42%   99.42%   -0.01%     
===========================================
  Files          299      299              
  Lines        22739    22691      -48     
===========================================
- Hits         22608    22560      -48     
  Misses         131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinsulzer]

This won't work well if there are multiple cycles (e.g. 5 times CCCV charge/discharge). Could it be done for each step in sol or would that be too slow?

[MarcBerliner]

This won't work well if there are multiple cycles (e.g. 5 times CCCV charge/discharge). Could it be done for each step in sol or would that be too slow?

@valentinsulzer good point – I actually meant to do this, but I misunderstood solutions to be the sub-solutions and not different simulations. I just pushed this change.

[valentinsulzer]

looks good to me other than style

[kratman]

Should be good after tests pass

[arjxn-py]

Hey @all-contributors please add @MarcBerliner for code, documentation, infrastructure and maintainance

[allcontributors]

@arjxn-py

I've put up a pull request to add @MarcBerliner! 🎉

[brosaplanella]

Hahah you beat me to it @arjxn-py

[arjxn-py]

Hahah you beat me to it @arjxn-py

Haha, I made a small mistake 😅

@all-contributors please add @MarcBerliner for Maintenance

[allcontributors]

@arjxn-py

I've put up a pull request to add @MarcBerliner! 🎉