-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chemistry dep warning #4466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is quite old and probably isn't in use anywhere either, but could you please add a CHANGELOG entry, too?
Yeah I was planning on it, I just needed to create the PR so I had the correct number |
You might like https://ichard26.github.io/next-pr-number/, I use it quite frequently for this purpose |
- Added phase-dependent particle options to LAM | ||
([#4369](https://github.com/pybamm-team/PyBaMM/pull/4369)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added phase-dependent particle options to LAM | |
([#4369](https://github.com/pybamm-team/PyBaMM/pull/4369)) | |
- Added phase-dependent particle options to LAM ([#4369](https://github.com/pybamm-team/PyBaMM/pull/4369)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of those render why does this matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would split up into a new line on https://pybamm.org/changelog/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already a bulleted list in that page, if that does not work then there is something wrong with the library used for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I notice, that page is outdated and does not show any results since 24.1 was last released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, the Goldmark renderer for Hugo has an option to wrap text, will check if it's enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kratman
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4466 +/- ##
========================================
Coverage 99.46% 99.46%
========================================
Files 293 293
Lines 22384 22386 +2
========================================
+ Hits 22264 22266 +2
Misses 120 120 ☔ View full report in Codecov by Sentry. |
Description
Remove the old deprecation warning for the chem argument. It was from March 2023, so over a year old
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: