-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4183 remove autograd #4196
#4183 remove autograd #4196
Conversation
Thanks! Could we unpin NumPy with this? It was recently pinned in #4186 |
Converting to draft as the interpolant differentation issue should be fixable |
Not obvious why Edit - looks like it was an issue caused by numpy 2.0, so I have kept numpy pinned to <2.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4196 +/- ##
===========================================
- Coverage 99.58% 99.54% -0.05%
===========================================
Files 288 288
Lines 21799 21857 +58
===========================================
+ Hits 21708 21757 +49
- Misses 91 100 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, happy to approve once coverage passes (I think some of the deleted tests brought the coverage down).
The problem with NumPy v2 is with this property that works on @value.setter
def value(self, value):
self._value = (
np.float64(value.item())
if isinstance(value, np.ndarray)
else np.float64(value)
) which with NumPy v2 returns |
I also got this error with numpy 2.0 when trying to run locally:
So I think we should leave it pinned and figure out unpinning it properly after the release |
Description
Removes autograd dependency and thus enables update to numpy 2.0.
The "differentiate numpy function directly" functionality, which relied on autograd, is deprecated, but I am not aware of any cases where it was being used, since we switched to implementing our own functions and specifying their derivatives.
Fixes #4183
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: