Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code of conduct to contributor covenant v2.1 #4171

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

santacodes
Copy link
Contributor

Description

Fixes #4160

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (0421fc3) to head (04b5fa1).
Report is 206 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4171   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          288      288           
  Lines        21770    21770           
========================================
  Hits         21679    21679           
  Misses          91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CODE-OF-CONDUCT.md Outdated Show resolved Hide resolved
CODE-OF-CONDUCT.md Outdated Show resolved Hide resolved
Co-authored-by: Arjun Verma <[email protected]>
@kratman
Copy link
Contributor

kratman commented Jun 12, 2024

@santacodes This same issue is on pybamm-cookiecutter. Can you fix it there as well?

@santacodes
Copy link
Contributor Author

@santacodes This same issue is on pybamm-cookiecutter. Can you fix it there as well?

Thank you for noticing, yes I did fix it!

@agriyakhetarpal
Copy link
Member

We should adapt Lychee to the cookiecutter repository as well, @santacodes.

@kratman kratman merged commit 91bfed4 into pybamm-team:develop Jun 12, 2024
26 checks passed
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* updated code of conduct to contributor covenant v2.1

* Update CODE-OF-CONDUCT.md

Co-authored-by: Arjun Verma <[email protected]>

---------

Co-authored-by: Arjun Verma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Code of Conduct
5 participants