-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated code of conduct to contributor covenant v2.1 #4171
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4171 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 288 288
Lines 21770 21770
========================================
Hits 21679 21679
Misses 91 91 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Arjun Verma <[email protected]>
@santacodes This same issue is on pybamm-cookiecutter. Can you fix it there as well? |
Thank you for noticing, yes I did fix it! |
We should adapt Lychee to the cookiecutter repository as well, @santacodes. |
* updated code of conduct to contributor covenant v2.1 * Update CODE-OF-CONDUCT.md Co-authored-by: Arjun Verma <[email protected]> --------- Co-authored-by: Arjun Verma <[email protected]>
Description
Fixes #4160
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: