Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind11 v2.12.0 #4151

Merged
merged 2 commits into from
Jun 7, 2024
Merged

pybind11 v2.12.0 #4151

merged 2 commits into from
Jun 7, 2024

Conversation

agriyakhetarpal
Copy link
Member

Description

Bump to pybind11 v2.12.0 to introduce upcoming NumPy v2 compatibility – it shouldn't be needed for our case because we don't build against the NumPy-C API but just to be sure, I tested the solvers against NumPy v2.0.0rc2 because the IDAKLU-Jax solver uses quite a few NumPy array in its implementation.

pybind11 is scheduled to be a build-time dependency through #3564, earlier through #3560.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (88002f1) to head (1e2c9f2).
Report is 200 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4151      +/-   ##
===========================================
+ Coverage    99.55%   99.58%   +0.02%     
===========================================
  Files          288      288              
  Lines        21817    21789      -28     
===========================================
- Hits         21720    21698      -22     
+ Misses          97       91       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, Thanks @agriyakhetarpal

@arjxn-py arjxn-py added the dependencies Pull requests that update a dependency file label Jun 7, 2024
@arjxn-py arjxn-py merged commit 6c01787 into pybamm-team:develop Jun 7, 2024
26 checks passed
@agriyakhetarpal agriyakhetarpal deleted the pybind-2.12 branch June 7, 2024 18:54
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* Pin pybind11 version in `pybamm-requires`

* Bump to v2.12.0 for benchmarks and wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants