-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ecker2015 solid-phase diffusivity functions to more closely match the paper #4141
Conversation
My preference would be to add a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the formula for D_s_n and D_s_p actually used by Ecker? I can't find it in Part I or Part II.
@@ -47,6 +48,7 @@ | |||
|
|||
## Breaking changes | |||
|
|||
- Updated solid-phase diffusivity functions in `Ecker2015` and `Ecker2015_graphite_halfcell` parameter sets to better match the original papers ([#4141](https://github.com/pybamm-team/PyBaMM/pull/4141)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be under only "breaking changes" or "features" instead of both
They don't give a formula, only data. It's possible that they used an interpolation between the data points. LiionDB has this data (I put it there!) so an alternative approach would be to use that. |
The solid-phase diffusivity functions in
Ecker2015
andEcker2015_graphite_halfcell
are updated to better match the functions in the original paper. A new citationYuan2023
, for which these parameters were used, is also added.Advantages:
Yuan2023
can be reproduced.Disadvantages:
ORegan2022
Richardson2019
are no longer reproduced. However, that paper still made a major contribution towards our understanding of theEcker2015
parameters and is therefore still cited.