-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: use casadi MX.interpn_linear function instead of plugin #3783 #4077
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4077 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 260 260
Lines 21358 21365 +7
========================================
+ Hits 21270 21277 +7
Misses 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Can you add a CHANGELOG entry before merging?
…eam#3783 (pybamm-team#4077) * bug: use casadi MX.interpn_linear function instead of plugin pybamm-team#3783 * bug: fix for 2d and 3d linear interpolant pybamm-team#3783 * cover cubic interpolation in 2d pybamm-team#3783 * pybamm-team#3783 add to changelog --------- Co-authored-by: Agriya Khetarpal <[email protected]>
Description
Partially fixes #3783
MX.interpn_linear
function instead ofinterpolant
for linear interpolationType of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: