Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plett OCP Hysteresis Model #3593
Plett OCP Hysteresis Model #3593
Changes from 18 commits
01dc550
809af01
a9ce212
13875ce
80a03d6
7d2026c
551b023
ab3f87d
a9f09d0
fc91c08
9388adf
7d4aa19
2463e2a
1bcb524
3e89fb4
27e075f
2e7d81b
5ae648b
e2fa1ed
9b0a4aa
e37031c
2ed9dea
c4f96c6
5fd1555
957755e
3324f40
d0be637
c2825aa
a16283a
cc64fb4
7952dbd
0ad1869
9e46865
746f811
e9dd55f
4f8bbbc
69beb4e
d379fb7
00a2e8e
8ad8214
2f947d9
9566f50
57240b8
ca414cb
668c5fe
eb2fe95
647be7b
ec466f0
6cab440
e72f799
f02551e
48fe678
31b7115
66f0ef1
1a8268c
5c169e2
f6fc3ad
d8f451e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a variable
f"{Domain} electrode capacity [A.h]"
defined in the active material model that does this calculation also accounting for any change in active material fractionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally I was calculating dQ(sto) by means of a function in the lithium ion parameters (main parameters for a phase I believe), but @valentinsulzer suggested placing it in the submodel class as a coupled variable.
Since dQ(sto) should be a constant value, I realized this could just be a scalar. Although, I am not sure whether it needs to be an equation as d(sto) may be different depending on the number of steps during solving. I still haven't tested this (looked at actual data or results) with the change from I made, so I am not sure if I will actually get the results I expect. All the more reason to make an example notebook.
I will make the example notebook and assess whether the function form of Q was necessary or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't
dQ
, right, it's just the electrode capacity? I think later on you are writingdU/dQ = dU/dx * dx/dQ
? Can you point to which equation the paper you've implemented as they seem to express it a few ways in the paper?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah my thinking here is that dQ(sto) would be equal to Q*sto, so maybe I need to multiply it by sto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it wasn't dQ. I believe I have since fixed it, and reverted back to the functional form of Q and taking the differential of that.
Here is the equation: