Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend pybamm_install_odes to include support for macOS systems #3417

Merged
merged 48 commits into from
Jan 6, 2024
Merged

Extend pybamm_install_odes to include support for macOS systems #3417

Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
148ea18
Test `pybamm_install_odes` on macOS on CI
arjxn-py Oct 6, 2023
d9743ec
Add parallel job
arjxn-py Oct 7, 2023
7c7420a
Test before unit tests in mac
arjxn-py Oct 7, 2023
906683b
Install `wget` before odes
arjxn-py Oct 7, 2023
a36ec4f
Merge branch 'develop' into install_odes
arjxn-py Oct 11, 2023
dda612a
Add parallel job to test `install_odes`
arjxn-py Oct 13, 2023
af43996
Install `pathlib` as required
arjxn-py Oct 14, 2023
7018c19
Remove condition
arjxn-py Oct 14, 2023
7f0bea9
Apply suggestions from code review
arjxn-py Oct 15, 2023
7ee2a9a
Correctly indent key
arjxn-py Oct 15, 2023
9728d17
Apply suggestions from code review
arjxn-py Oct 15, 2023
559a703
Merge branch 'develop' into install_odes
arjxn-py Oct 20, 2023
2713ce5
Add `.zshrc` for macOS
arjxn-py Oct 20, 2023
8db4f7c
Install required modules before initializing
arjxn-py Oct 20, 2023
45de356
Using f-strings instead of `format()`
arjxn-py Oct 20, 2023
4a8f13c
gitignore `scikits_odes_setup.log`
arjxn-py Oct 20, 2023
edcccf5
Update doc in solver section for `install_odes`
arjxn-py Oct 20, 2023
9655550
Exit early on windows
arjxn-py Oct 20, 2023
6150207
Merge branch 'develop' into install_odes
arjxn-py Oct 20, 2023
8b33770
Changelog
arjxn-py Oct 20, 2023
ac803c5
Remove cache before installation
arjxn-py Oct 20, 2023
0ed80bb
Applied suggestions
arjxn-py Oct 23, 2023
2698a87
Move `test_install_odes` to scheduled
arjxn-py Oct 23, 2023
c062b17
Check platform without function
arjxn-py Oct 24, 2023
e3c62b5
Import module with importlib
arjxn-py Oct 24, 2023
79539f4
Define sundials version on top
arjxn-py Oct 24, 2023
6292cbf
Detect terminal with `os.environ`
arjxn-py Oct 24, 2023
b9668f7
Merge branch 'develop' into install_odes
arjxn-py Nov 5, 2023
53c358d
Merge branch 'develop' into install_odes
arjxn-py Nov 17, 2023
7464857
Resolve merge conflicts & merge to develop
arjxn-py Dec 16, 2023
777850c
Merge branch 'develop' into install_odes
arjxn-py Dec 16, 2023
60c6e02
Prevent separate function to install dependencies
arjxn-py Dec 17, 2023
c8266ed
Check for shell files directly
arjxn-py Dec 20, 2023
4979598
Merge branch 'develop' into install_odes
arjxn-py Dec 22, 2023
7e0cc70
Add note to avoid installation failure
arjxn-py Dec 22, 2023
15e0597
Add note for path validation
arjxn-py Dec 23, 2023
6221017
Apply suggestions from code review
arjxn-py Dec 23, 2023
b8eaaab
Rename file & suggested fixes
arjxn-py Dec 23, 2023
4e1dbec
Set `CMAKE_BUILD_PARALLEL_LEVEL`
arjxn-py Dec 23, 2023
e770c92
Fix broken doctree due to rename
arjxn-py Dec 23, 2023
34d3e6b
Fix title underline
arjxn-py Dec 23, 2023
e766cca
Fix table malformation
arjxn-py Dec 23, 2023
96d63de
Add non-fixable link to `.lycheeignore`
arjxn-py Dec 23, 2023
dddea9c
Merge branch 'develop' into install_odes
arjxn-py Dec 24, 2023
430c86f
style: pre-commit fixes
pre-commit-ci[bot] Dec 24, 2023
6aa6685
Apply suggestions from code review
arjxn-py Dec 24, 2023
ed3f741
Merge branch 'pybamm-team:develop' into install_odes
agriyakhetarpal Dec 27, 2023
738cd57
Use `python -m pip` invocation instead
agriyakhetarpal Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@ jobs:
pip install --upgrade pip wheel setuptools nox
pip install -e .[all,docs]

- name: Test pybamm_install_odes on MacOS (for only this PR)
if: matrix.os == 'macos-latest'
run: pybamm_install_odes
arjxn-py marked this conversation as resolved.
Show resolved Hide resolved

- name: Install docs dependencies and run doctests for GNU/Linux with Python 3.11
run: nox -s doctests

Expand Down
Loading