Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix URL Checker #3393

Merged
merged 12 commits into from
Oct 8, 2023
Merged

fix: Fix URL Checker #3393

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8747dd9
fix: Broken link
Agnik7 Oct 2, 2023
cbec0e9
Update CHANGELOG.md
Agnik7 Oct 2, 2023
3ebb05f
Update CHANGELOG.md
Agnik7 Oct 2, 2023
278bdf4
Update CONTRIBUTING.md
Agnik7 Oct 2, 2023
cf4ead6
Update CONTRIBUTING.md
Agnik7 Oct 2, 2023
956f4eb
Merge branch 'pybamm-team:develop' into develop
Agnik7 Oct 3, 2023
c4faa5c
Merge branch 'pybamm-team:develop' into develop
Agnik7 Oct 4, 2023
df9a36e
Merge branch 'pybamm-team:develop' into develop
Agnik7 Oct 5, 2023
211f349
Merge branch 'pybamm-team:develop' into develop
Agnik7 Oct 7, 2023
96eef72
Fix URL
Agnik7 Oct 8, 2023
f5ddab3
Update .all-contributorsrc
Agnik7 Oct 8, 2023
bc909c3
Update CONTRIBUTING.md
Agnik7 Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ You may also test multiple notebooks this way. Passing the path to a folder will
nox -s examples -- docs/source/examples/notebooks/models/
```

You may also use an appropriate [glob pattern](https://www.malikbrowne.com/blog/a-beginners-guide-glob-patterns) to run all notebooks matching a particular folder or name pattern.
You may also use an appropriate [glob pattern](https://developers.tetrascience.com/docs/common-glob-pattern) to run all notebooks matching a particular folder or name pattern.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a link to another software package. Is there something more general that could be used? Like Linux documentation or python documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kratman I have changed the link to a Linux documentation link. Is it alright? Please check


To edit the structure and how the Jupyter notebooks get rendered in the Sphinx documentation (using `nbsphinx`), install [Pandoc](https://pandoc.org/installing.html) on your system, either using `conda` (through the `conda-forge` channel)

Expand Down