Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix periodic benchmarks and remove version cap on asv #3379

Merged
merged 4 commits into from
Sep 30, 2023

Conversation

agriyakhetarpal
Copy link
Member

Description

The scheduled benchmarks suite was failing to run because the version was not pinned to 0.5.1. This PR resolves both benchmarks workflows and allows the benchmarks to run

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fc570af) 99.56% compared to head (e2d9397) 99.58%.
Report is 54 commits behind head on develop.

❗ Current head e2d9397 differs from pull request most recent head 04713c6. Consider uploading reports for the commit 04713c6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3379      +/-   ##
===========================================
+ Coverage    99.56%   99.58%   +0.01%     
===========================================
  Files          253      254       +1     
  Lines        19559    19815     +256     
===========================================
+ Hits         19474    19732     +258     
+ Misses          85       83       -2     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agriyakhetarpal! Some comments below -

.github/workflows/benchmark_on_push.yml Show resolved Hide resolved
.github/workflows/periodic_benchmarks.yml Show resolved Hide resolved
.github/workflows/benchmark_on_push.yml Outdated Show resolved Hide resolved
.github/workflows/periodic_benchmarks.yml Outdated Show resolved Hide resolved
@Saransh-cpp Saransh-cpp merged commit 7eb5879 into pybamm-team:develop Sep 30, 2023
29 of 30 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix-benchmarks branch September 30, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants