-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickplot to catch empty lists #3359
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3359 +/- ##
===========================================
- Coverage 99.57% 99.56% -0.02%
===========================================
Files 253 253
Lines 19571 19555 -16
===========================================
- Hits 19488 19470 -18
- Misses 83 85 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of things before approving. Can you address the small comment on the test and add an entry to the CHANGELOG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you commit the suggested change? Happy to merge afterwards
Co-authored-by: Ferran Brosa Planella <[email protected]>
@all-contributors please add @kratman for tests |
I've put up a pull request to add @kratman! 🎉 |
Description
I added some error handling for QuickPlot when an empty list is passed as the first argument.
Changes:
QuickPlot([])
Fixes #3172
Type of change
Minor bug fix for catching empty input lists.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: