-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve memory use in experiments #3261
Improve memory use in experiments #3261
Conversation
…1-improve-memory-experiments
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3261 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 253 253
Lines 19553 19558 +5
========================================
+ Hits 19466 19471 +5
Misses 87 87
☔ View full report in Codecov by Sentry. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @brosaplanella looks good to me!
Description
Improve memory use in experiments by redefining what steps are unique. Two steps are considered the same if
type
,value
,termination
andtemperature
are the same, as these are the variables used when processing the model. The remaining variables are only used when running the model and can be passed as inputs. I have also defined abasic_repr
which returns a representation with only those variables, while__repr__
returns a representation with all the variables.Fixes #3081
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: