Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2954 turn off benchmark: ORegan2022 DFN solver with the casadi model #3031

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

martinjrobins
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2954

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (08b9d5e) 99.71% compared to head (8c455d6) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3031   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18681    18736   +55     
========================================
+ Hits         18627    18682   +55     
  Misses          54       54           

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martinjrobins martinjrobins marked this pull request as ready for review July 3, 2023 10:39
@martinjrobins
Copy link
Contributor Author

benchmarks still failling due to regressions in timings, but I think this PR as is will fix a lot of the failing simulations we've been getting

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@martinjrobins martinjrobins merged commit 6b642a6 into develop Jul 6, 2023
@martinjrobins martinjrobins deleted the i2954-benchmark-intermitant-failure branch July 6, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track down and exclude non-deterministic benchmarks
3 participants