-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jax to 0.4.8 #2927
Update Jax to 0.4.8 #2927
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2927 +/- ##
===========================================
+ Coverage 99.68% 99.71% +0.02%
===========================================
Files 273 273
Lines 18997 18991 -6
===========================================
- Hits 18938 18936 -2
+ Misses 59 55 -4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Happy to merge one Martin has reviewed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @jsbrittain
Description
Update Jax (from 0.2.12 to 0.4.8) and JaxLib (from 0.1.70 to 0.4.7). There were several breaking changes in the Jax interface between these versions.
Fixes #1625
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
Further checks:
Tests added that prove fix is effective or that feature worksRefactor of existing code
Note: The Jax library appears to be evolving rapidly, so I have pinned the current version.