-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow particle size to be a tuple and fix MPM half-cell #2672
Conversation
Codecov ReportBase: 99.69% // Head: 99.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2672 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 271 271
Lines 19571 19586 +15
========================================
+ Hits 19511 19526 +15
Misses 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. How much effort is fixing the coverage?
Description
"Particle size" can now be a tuple to allow different behaviour in each electrode.
MPM
now works as a half-cell model, and no longer requires the user to provide distribution parameters for both electrodes.Also allows SPM(e) to have size distributions so that users can create more customised models (e.g. SPMe with a size distribution in one electrode only)
Fixes #2669
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: