Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional for scaling of r-R plots #2663

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Remove conditional for scaling of r-R plots #2663

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca7dd19
Remove conditional for scaling of r-R plots
iatzak Feb 6, 2023
d61b36b
changelog
iatzak Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions pybamm/solvers/processed_variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,14 +362,9 @@ def initialise_2D(self):
# assign attributes for reference
self.entries = entries
self.dimensions = 2
if self.first_dimension == "r" and self.second_dimension == "R":
# for an r-R variable, must leave r nondimensional as it was scaled using
# R
first_length_scale = 1
else:
first_length_scale = self.get_spatial_scale(
self.first_dimension, self.domain[0]
)
first_length_scale = self.get_spatial_scale(
self.first_dimension, self.domain[0]
)
first_dim_pts_for_interp = first_dim_pts * first_length_scale

second_length_scale = self.get_spatial_scale(
Expand Down