-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colab and pybtex issue #2526
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2526 +/- ##
========================================
Coverage 99.72% 99.72%
========================================
Files 268 268
Lines 19311 19315 +4
========================================
+ Hits 19258 19262 +4
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Valentin Sulzer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks! Will merge when tests pass
@@ -64,6 +66,12 @@ def test_print_citations(self): | |||
with self.assertRaisesRegex(pybamm.OptionError, "'text' or 'bibtex'"): | |||
pybamm.print_citations("test_citations.txt", "bad format") | |||
|
|||
# google colab issue - https://github.com/pybamm-team/PyBaMM/issues/2524 | |||
sys.modules["google.colab"] = "mock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Description
This looks like this right now -
Now that I think of it, it might be better to not show a warning on importing pybamm (would be too noisy). Rather, we could do -
and then -
Fixes #2524
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: