-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.10 and 3.11 #2435
Conversation
tox.ini
Outdated
@@ -2,6 +2,7 @@ | |||
envlist = {windows}-{tests,unit,dev},tests,unit,dev,julia | |||
|
|||
[testenv] | |||
pip_pre = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More specifically, before merging this PR, we should remove this, and this can be removed once casadi publishes a "non-pre" release.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2435 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 273 273
Lines 19071 19071
========================================
Hits 19012 19012
Misses 59 59 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Reverting Python version until pybamm-team#2435 is merged
Reverting python version until pybamm-team#2435 is merged
.github/workflows/test_on_push.yml
Outdated
@@ -46,7 +46,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [ubuntu-latest, macos-latest, windows-latest] | |||
python-version: [3.8, 3.9] | |||
python-version: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also try Python 3.11?
Looks like this is working! Will rebase once #2859 is merged and this should be ready for a review then. |
Also, should there be a CHANGELOG entry for #2346? Saying something like - "PyBaMM is now natively supported on Apple silicon chips"? Edit: I think we should also bump the minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Yes, I think we should add a line in CHANGELOG about Mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! merging
Hi there, Considering that the support for Python 3.10 is listed here as "unreleased", would that mean that I cannot currently use PyBamm with Python 3.10? If I can, please help explain how to do so. If I cannot, could you please let me know approximately when the support for 3.10 would be released? |
At the moment it is only available if you install from source, but we aim to make a release in the next few days. |
Description
Casadi has published a couple of pre-releases with Python 3.10 support - https://pypi.org/project/casadi/3.5.6.pre2/#files!!
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: