-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove FOQS and Composite lead-acid models #2431
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportBase: 99.71% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2431 +/- ##
===========================================
+ Coverage 99.71% 99.72% +0.01%
===========================================
Files 267 258 -9
Lines 20044 19498 -546
===========================================
- Hits 19987 19445 -542
+ Misses 57 53 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@@ -1,5 +1,9 @@ | |||
# [Unreleased](https://github.com/pybamm-team/PyBaMM/) | |||
|
|||
## Breaking changes | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised that I placed the asymmetric SEI line of the CHANGELOG in the 22.10 release. Can you move it to the unreleased? Sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do it in the other PR which needs a changelog
Description
I don't think anyone is using these models, and they aren't much faster than the full model anyway. They are very different from the other models which makes them hard to maintain / large technical debt.
Let me know if you don't want these models removed (or you find this PR in future and want them added back in)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: