Composite sei

[valentinsulzer]

Description

Adds SEI model for composite electrodes, with test for silicon/graphite

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Base: 99.40% // Head: 99.40% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cf767e3) compared to base (669af80).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2290   +/-   ##
========================================
  Coverage    99.40%   99.40%           
========================================
  Files          364      365    +1     
  Lines        20040    20061   +21     
========================================
+ Hits         19920    19941   +21     
  Misses         120      120           

Impacted Files	Coverage Δ
pybamm/models/standard_variables.py	100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py	100.00% <ø> (ø)
...m/models/full_battery_models/base_battery_model.py	99.78% <100.00%> (ø)
...l_battery_models/lead_acid/base_lead_acid_model.py	100.00% <100.00%> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py	100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py	100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/spm.py	100.00% <100.00%> (ø)
...submodels/active_material/total_active_material.py	100.00% <100.00%> (ø)
...ybamm/models/submodels/interface/base_interface.py	100.00% <100.00%> (ø)
...dels/submodels/interface/kinetics/base_kinetics.py	100.00% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[rtimms]

thanks @tinosulzer looks good!