-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added throughput variables for degradation sudies #2249
Conversation
…te discharge energy' is false
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
did you mean to add all of these additional files (coupled_degradation.ipynb, etc)? |
Codecov Report
@@ Coverage Diff @@
## develop #2249 +/- ##
========================================
Coverage 99.36% 99.36%
========================================
Files 355 357 +2
Lines 19499 19524 +25
========================================
+ Hits 19375 19400 +25
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…OKane2022 parameters
I did mean to add lipf6_OKane2022, yes. I should have done this in the same PR as SEi on cracks but forgot! coupled_degradation has been removed. I do want to add it eventually but there's still a lot of debugging to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why but the tests aren't running (edit: managed to trigger)
Description
Added new cumulative variables "Throughput capacity [A.h]" and "Throughput energy [W.h]" to standard variables and summary variables. "Time [s]" and "Time [h]" are also now summary variables. This is designed to make it easier to conduct degradation studies using the save_at_cycles feature.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: