Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected initial SEI thickness for OKane2022 parameters #2218

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

DrSOKane
Copy link
Contributor

@DrSOKane DrSOKane commented Aug 8, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2218 (2fd114e) into develop (96aaa75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2218   +/-   ##
========================================
  Coverage    99.36%   99.36%           
========================================
  Files          355      355           
  Lines        19499    19499           
========================================
  Hits         19375    19375           
  Misses         124      124           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@valentinsulzer valentinsulzer merged commit 2f3c3fa into pybamm-team:develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants