-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up electrode SOH calculations #2199
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2199 +/- ##
========================================
Coverage 99.36% 99.36%
========================================
Files 355 355
Lines 19451 19506 +55
========================================
+ Hits 19327 19382 +55
Misses 124 124
Continue to review full report at Codecov.
|
Would be good to merge this before the new release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, feel free to merge once you have updated the CHANGELOG
pybamm/solvers/solution.py
Outdated
@@ -864,7 +862,7 @@ def get_cycle_summary_variables(cycle_solution, esoh_sims): | |||
} | |||
) | |||
|
|||
# Voltage variables | |||
# # Voltage variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# # Voltage variables | |
# Voltage variables |
Description
Speed up some performance regressions introduced in #2192
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: