-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move submodels and build model #2169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Rob!
Codecov Report
@@ Coverage Diff @@
## develop #2169 +/- ##
===========================================
- Coverage 99.38% 99.35% -0.03%
===========================================
Files 356 356
Lines 19309 19357 +48
===========================================
+ Hits 19190 19233 +43
- Misses 119 124 +5
Continue to review full report at Codecov.
|
Description
Move general code about submodels to
BaseModel
instead ofBaseBatteryModel
. This makes it easier to build custom models from submodels.Also fixes a bug where SPMe always build even when
build=False
.Fixes #2056 #2168
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: