Issue 2026 total reaction

[valentinsulzer]

Description

Creates a separate submodel for the total kinetics ("sum of ...." variables
Continuing to break up #2073

Fixes #2026

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #2144 (864cfcb) into develop (6a51492) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2144      +/-   ##
===========================================
- Coverage    99.38%   99.38%   -0.01%     
===========================================
  Files          355      356       +1     
  Lines        19308    19297      -11     
===========================================
- Hits         19189    19178      -11     
  Misses         119      119              

Impacted Files	Coverage Δ
...m/models/full_battery_models/base_battery_model.py	99.76% <ø> (-0.01%)	⬇️
...etics/first_order_kinetics/first_order_kinetics.py	100.00% <ø> (ø)
...ubmodels/interface/lithium_plating/base_plating.py	100.00% <ø> (ø)
...els/interface/open_circuit_potential/single_ocp.py	100.00% <ø> (ø)
...l_battery_models/lead_acid/base_lead_acid_model.py	100.00% <100.00%> (ø)
...ybamm/models/full_battery_models/lead_acid/full.py	100.00% <100.00%> (ø)
...dels/full_battery_models/lead_acid/higher_order.py	98.16% <100.00%> (+0.01%)	⬆️
...ybamm/models/full_battery_models/lead_acid/loqs.py	100.00% <100.00%> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py	100.00% <100.00%> (ø)
...tential_form/explicit_surface_form_conductivity.py	95.00% <100.00%> (-0.24%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a51492...864cfcb. Read the comment docs.

[rtimms]

thanks, @tinosulzer looks good! just a couple of minor comments

[rtimms]

can you add a more detailed comment here? on first read setting a to zero seems wrong

[rtimms]

Yeah that’s clearer, thanks!

[brosaplanella]

Looks good, thanks @tinosulzer!