-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/esoh model update #2109
Closed
anoushka2000
wants to merge
29
commits into
pybamm-team:develop
from
anoushka2000:feature/esoh_model_update
Closed
feature/esoh model update #2109
anoushka2000
wants to merge
29
commits into
pybamm-team:develop
from
anoushka2000:feature/esoh_model_update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_update # Conflicts: # examples/notebooks/models/electrode-state-of-health.ipynb
valentinsulzer
requested changes
Jun 28, 2022
…feature/esoh_model_update
Codecov Report
@@ Coverage Diff @@
## develop #2109 +/- ##
===========================================
- Coverage 99.38% 99.30% -0.08%
===========================================
Files 356 356
Lines 19297 19409 +112
===========================================
+ Hits 19178 19274 +96
- Misses 119 135 +16
Continue to review full report at Codecov.
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1856 and #1842 (issue)
Makes electrode state of health model more robust by calculating initial conditions based on model parameters and solving model in two stages (separating solution for stoichiometry
x_100
and capacityC
).Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: