Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bound sto for better eSOH results #2095

Merged
merged 4 commits into from
Jun 13, 2022
Merged

bound sto for better eSOH results #2095

merged 4 commits into from
Jun 13, 2022

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Jun 8, 2022

Description

Bound stoichiometry for OCV between 1e-10 and 1-1e-10. Together with the singularities introduced at 0 and 1, this ensures that the eSOH results are always between 0 and 1.

Fixes #1856

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2095 (27f8cec) into develop (bc72c6d) will decrease coverage by 0.00%.
The diff coverage is 99.48%.

@@             Coverage Diff             @@
##           develop    #2095      +/-   ##
===========================================
- Coverage    99.38%   99.38%   -0.01%     
===========================================
  Files          348      348              
  Lines        19255    19234      -21     
===========================================
- Hits         19136    19115      -21     
  Misses         119      119              
Impacted Files Coverage Δ
pybamm/spatial_methods/spatial_method.py 96.36% <ø> (ø)
pybamm/spatial_methods/finite_volume.py 98.15% <92.30%> (ø)
pybamm/discretisations/discretisation.py 99.79% <100.00%> (ø)
pybamm/expression_tree/binary_operators.py 99.53% <100.00%> (-0.01%) ⬇️
pybamm/expression_tree/concatenations.py 98.70% <100.00%> (-0.04%) ⬇️
pybamm/expression_tree/functions.py 100.00% <100.00%> (ø)
...mm/expression_tree/operations/convert_to_casadi.py 100.00% <100.00%> (ø)
...ybamm/expression_tree/operations/evaluate_julia.py 100.00% <100.00%> (ø)
...bamm/expression_tree/operations/evaluate_python.py 98.29% <100.00%> (ø)
pybamm/expression_tree/operations/jacobian.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98b446...27f8cec. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 9d3b1c3 into develop Jun 13, 2022
@valentinsulzer valentinsulzer deleted the bound-ocv branch June 13, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not solve for summary variables error for certain experiment values
2 participants