-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ocp as a separate submodel #2094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tinosulzer looks good!
self.set_crack_submodel() | ||
self.set_active_material_submodel() | ||
self.set_transport_efficiency_submodels() | ||
self.set_convection_submodel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think you need to move the defn of set_convection_submodel
into this file from SPM, SPMe, DFN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, actually it looks like this has broken the half-cell models?
Codecov Report
@@ Coverage Diff @@
## develop #2094 +/- ##
========================================
Coverage 99.38% 99.38%
========================================
Files 352 355 +3
Lines 19289 19302 +13
========================================
+ Hits 19170 19183 +13
Misses 119 119
Continue to review full report at Codecov.
|
Description
Adds OCV as a submodel. Currently there is only one kind of submodel, but #2073 will be adding the current sigmoid.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: