-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface form half cell #1913
Surface form half cell #1913
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1913 +/- ##
===========================================
+ Coverage 99.31% 99.32% +0.01%
===========================================
Files 346 346
Lines 19105 19124 +19
===========================================
+ Hits 18974 18995 +21
+ Misses 131 129 -2
Continue to review full report at Codecov.
|
Co-authored-by: Priyanshu Agarwal <[email protected]>
…M into surface-form-half-cell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tinosulzer looks good!
Description
Fixes half-cell models so that they can be run with "surface form"
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: