-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback #1880
Callback #1880
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1880 +/- ##
===========================================
- Coverage 99.37% 99.35% -0.02%
===========================================
Files 347 347
Lines 19136 18735 -401
===========================================
- Hits 19016 18615 -401
Misses 120 120
Continue to review full report at Codecov.
|
@martinjrobins I think this could be useful for automatically uploading simulation results from a script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Tino! I guess we should extend the example notebook but we can do this in the future. Before merging, you need to update CHANGELOG.
Description
Add callback hooks to
Simulation.solve
and a move some logging steps to the callbackType of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: