-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve experiment with drive cycle #1793
Solve experiment with drive cycle #1793
Conversation
This commit simulates drive cycle ('A' or 'V' or 'W') in experiment only if drive cycle of particular type is initial instruction in experiment and there are no further drive cycle related instructions.
…experiment-drive-cycle
@alibh95 for some reason I can't request a review from you, but please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking this on @brosaplanella
Codecov Report
@@ Coverage Diff @@
## develop #1793 +/- ##
========================================
Coverage 99.28% 99.29%
========================================
Files 343 343
Lines 18945 18966 +21
========================================
+ Hits 18810 18832 +22
+ Misses 135 134 -1
Continue to review full report at Codecov.
|
Looks good to me. Thank you so much for implementing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, cheers
Description
Experiments now allow to solve for drive cycles.
Fixes #1788 and includes #1524
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: