Add half cell submodels

[valentinsulzer]

Description

Edit submodels to allow half-cell options without needing to rewrite the entire submodel

Fixes #1518

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[brosaplanella]

That looks great Tino, thanks! Just a very few minor comments.

[brosaplanella]

``

[valentinsulzer]

@molel-gt you can take a look now if you want

[codecov]

Codecov Report

Merging #1600 (54e70dc) into develop (d4e95f7) will increase coverage by 0.01%.
The diff coverage is 99.76%.

@@             Coverage Diff             @@
##           develop    #1600      +/-   ##
===========================================
+ Coverage    99.26%   99.28%   +0.01%     
===========================================
  Files          343      342       -1     
  Lines        18659    18766     +107     
===========================================
+ Hits         18522    18631     +109     
+ Misses         137      135       -2     

Impacted Files	Coverage Δ
pybamm/expression_tree/symbol.py	98.98% <ø> (+0.73%)	⬆️
...s/full_battery_models/lithium_ion/electrode_soh.py	100.00% <ø> (ø)
...tery_models/lithium_ion/electrode_soh_half_cell.py	100.00% <ø> (ø)
...amm/models/full_battery_models/lithium_ion/spme.py	100.00% <ø> (ø)
...lectrolyte_conductivity/integrated_conductivity.py	100.00% <ø> (ø)
...trolyte_conductivity/leading_order_conductivity.py	100.00% <ø> (ø)
...ential_form/composite_surface_form_conductivity.py	100.00% <ø> (ø)
...e_potential_form/full_surface_form_conductivity.py	100.00% <ø> (ø)
...otential_form/leading_surface_form_conductivity.py	100.00% <ø> (ø)
...ubmodels/oxygen_diffusion/base_oxygen_diffusion.py	100.00% <ø> (ø)
... and 51 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e95f7...54e70dc. Read the comment docs.

[molel-gt]

@molel-gt you can take a look now if you want

sure, I'm gonna try running simulations first and comment with any errors or unexpected results

[valentinsulzer]

I've merged the branch since the tests passed, feel free to still suggest changes

[molel-gt]

Thank you. I caught some errors, but I need to check that it's not because of my local environment setup.

…

________________________________ From: Valentin Sulzer ***@***.***> Sent: Thursday, September 9, 2021 4:23 PM To: pybamm-team/PyBaMM ***@***.***> Cc: Molel, Leshinka ***@***.***>; Mention ***@***.***> Subject: Re: [pybamm-team/PyBaMM] Add half cell submodels (#1600) I've merged the branch since the tests passed, feel free to still suggest changes — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1600 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATK6DZS4GJSQQBTHDOKTMYLUBEJV5ANCNFSM5B2M76PQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.