Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ec sei bug #1397

Merged
merged 10 commits into from
Mar 1, 2021
Merged

Ec sei bug #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0233433
fix EC SEI bug
valentinsulzer Feb 19, 2021
0c69f7b
fix moles lost variable
valentinsulzer Feb 19, 2021
267987d
fix scales
valentinsulzer Feb 20, 2021
654c8a8
Merge branch 'develop' into ec-sei-bug
valentinsulzer Feb 22, 2021
a5eea63
fix number of mols lost
valentinsulzer Feb 22, 2021
41c6ff9
fix sei in parameter sets
valentinsulzer Feb 23, 2021
a2b1266
fix tests
valentinsulzer Feb 27, 2021
cb412a6
reformat EC SEI to get rid of algebraic equation
valentinsulzer Feb 27, 2021
e5bc823
Merge branch 'develop' into ec-sei-bug
valentinsulzer Mar 1, 2021
7ffd0ca
changelog
valentinsulzer Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
## Bug fixes

- Fixed a sign error in the positive electrode ohmic losses ([#1407](https://github.com/pybamm-team/PyBaMM/pull/1407))
- Fixed the formulation of the EC reaction SEI model ([#1397](https://github.com/pybamm-team/PyBaMM/pull/1397))
- Simulations now stop when an experiment becomes infeasible ([#1395](https://github.com/pybamm-team/PyBaMM/pull/1395))
- Added a check for domains in `Concatenation` ([#1368](https://github.com/pybamm-team/PyBaMM/pull/1368))
- Differentiation now works even when the differentiation variable is a constant ([#1294](https://github.com/pybamm-team/PyBaMM/pull/1294))
Expand Down
144 changes: 72 additions & 72 deletions examples/notebooks/Getting Started/Tutorial 3 - Basic plotting.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,70 +310,70 @@
" 'Volume-averaged cell temperature [K]',\n",
" 'Ambient temperature [K]',\n",
" 'Ambient temperature',\n",
" 'Inner negative electrode sei thickness',\n",
" 'Inner negative electrode sei thickness [m]',\n",
" 'X-averaged inner negative electrode sei thickness',\n",
" 'X-averaged inner negative electrode sei thickness [m]',\n",
" 'Outer negative electrode sei thickness',\n",
" 'Outer negative electrode sei thickness [m]',\n",
" 'X-averaged outer negative electrode sei thickness',\n",
" 'X-averaged outer negative electrode sei thickness [m]',\n",
" 'Total negative electrode sei thickness',\n",
" 'Total negative electrode sei thickness [m]',\n",
" 'X-averaged total negative electrode sei thickness',\n",
" 'X-averaged total negative electrode sei thickness [m]',\n",
" 'Inner negative electrode SEI thickness',\n",
" 'Inner negative electrode SEI thickness [m]',\n",
" 'X-averaged inner negative electrode SEI thickness',\n",
" 'X-averaged inner negative electrode SEI thickness [m]',\n",
" 'Outer negative electrode SEI thickness',\n",
" 'Outer negative electrode SEI thickness [m]',\n",
" 'X-averaged outer negative electrode SEI thickness',\n",
" 'X-averaged outer negative electrode SEI thickness [m]',\n",
" 'Total negative electrode SEI thickness',\n",
" 'Total negative electrode SEI thickness [m]',\n",
" 'X-averaged total negative electrode SEI thickness',\n",
" 'X-averaged total negative electrode SEI thickness [m]',\n",
" 'X-averaged negative electrode resistance [Ohm.m2]',\n",
" 'Inner negative electrode sei concentration [mol.m-3]',\n",
" 'X-averaged inner negative electrode sei concentration [mol.m-3]',\n",
" 'Outer negative electrode sei concentration [mol.m-3]',\n",
" 'X-averaged outer negative electrode sei concentration [mol.m-3]',\n",
" 'Negative sei concentration [mol.m-3]',\n",
" 'X-averaged negative electrode sei concentration [mol.m-3]',\n",
" 'Loss of lithium to negative electrode sei [mol]',\n",
" 'Inner negative electrode sei interfacial current density',\n",
" 'Inner negative electrode sei interfacial current density [A.m-2]',\n",
" 'X-averaged inner negative electrode sei interfacial current density',\n",
" 'X-averaged inner negative electrode sei interfacial current density [A.m-2]',\n",
" 'Outer negative electrode sei interfacial current density',\n",
" 'Outer negative electrode sei interfacial current density [A.m-2]',\n",
" 'X-averaged outer negative electrode sei interfacial current density',\n",
" 'X-averaged outer negative electrode sei interfacial current density [A.m-2]',\n",
" 'Negative electrode sei interfacial current density',\n",
" 'Negative electrode sei interfacial current density [A.m-2]',\n",
" 'X-averaged negative electrode sei interfacial current density',\n",
" 'X-averaged negative electrode sei interfacial current density [A.m-2]',\n",
" 'Inner positive electrode sei thickness',\n",
" 'Inner positive electrode sei thickness [m]',\n",
" 'X-averaged inner positive electrode sei thickness',\n",
" 'X-averaged inner positive electrode sei thickness [m]',\n",
" 'Outer positive electrode sei thickness',\n",
" 'Outer positive electrode sei thickness [m]',\n",
" 'X-averaged outer positive electrode sei thickness',\n",
" 'X-averaged outer positive electrode sei thickness [m]',\n",
" 'Total positive electrode sei thickness',\n",
" 'Total positive electrode sei thickness [m]',\n",
" 'X-averaged total positive electrode sei thickness',\n",
" 'X-averaged total positive electrode sei thickness [m]',\n",
" 'Inner negative electrode SEI concentration [mol.m-3]',\n",
" 'X-averaged inner negative electrode SEI concentration [mol.m-3]',\n",
" 'Outer negative electrode SEI concentration [mol.m-3]',\n",
" 'X-averaged outer negative electrode SEI concentration [mol.m-3]',\n",
" 'Negative SEI concentration [mol.m-3]',\n",
" 'X-averaged negative electrode SEI concentration [mol.m-3]',\n",
" 'Loss of lithium to negative electrode SEI [mol]',\n",
" 'Inner negative electrode SEI interfacial current density',\n",
" 'Inner negative electrode SEI interfacial current density [A.m-2]',\n",
" 'X-averaged inner negative electrode SEI interfacial current density',\n",
" 'X-averaged inner negative electrode SEI interfacial current density [A.m-2]',\n",
" 'Outer negative electrode SEI interfacial current density',\n",
" 'Outer negative electrode SEI interfacial current density [A.m-2]',\n",
" 'X-averaged outer negative electrode SEI interfacial current density',\n",
" 'X-averaged outer negative electrode SEI interfacial current density [A.m-2]',\n",
" 'Negative electrode SEI interfacial current density',\n",
" 'Negative electrode SEI interfacial current density [A.m-2]',\n",
" 'X-averaged negative electrode SEI interfacial current density',\n",
" 'X-averaged negative electrode SEI interfacial current density [A.m-2]',\n",
" 'Inner positive electrode SEI thickness',\n",
" 'Inner positive electrode SEI thickness [m]',\n",
" 'X-averaged inner positive electrode SEI thickness',\n",
" 'X-averaged inner positive electrode SEI thickness [m]',\n",
" 'Outer positive electrode SEI thickness',\n",
" 'Outer positive electrode SEI thickness [m]',\n",
" 'X-averaged outer positive electrode SEI thickness',\n",
" 'X-averaged outer positive electrode SEI thickness [m]',\n",
" 'Total positive electrode SEI thickness',\n",
" 'Total positive electrode SEI thickness [m]',\n",
" 'X-averaged total positive electrode SEI thickness',\n",
" 'X-averaged total positive electrode SEI thickness [m]',\n",
" 'X-averaged positive electrode resistance [Ohm.m2]',\n",
" 'Inner positive electrode sei concentration [mol.m-3]',\n",
" 'X-averaged inner positive electrode sei concentration [mol.m-3]',\n",
" 'Outer positive electrode sei concentration [mol.m-3]',\n",
" 'X-averaged outer positive electrode sei concentration [mol.m-3]',\n",
" 'Positive sei concentration [mol.m-3]',\n",
" 'X-averaged positive electrode sei concentration [mol.m-3]',\n",
" 'Loss of lithium to positive electrode sei [mol]',\n",
" 'Inner positive electrode sei interfacial current density',\n",
" 'Inner positive electrode sei interfacial current density [A.m-2]',\n",
" 'X-averaged inner positive electrode sei interfacial current density',\n",
" 'X-averaged inner positive electrode sei interfacial current density [A.m-2]',\n",
" 'Outer positive electrode sei interfacial current density',\n",
" 'Outer positive electrode sei interfacial current density [A.m-2]',\n",
" 'X-averaged outer positive electrode sei interfacial current density',\n",
" 'X-averaged outer positive electrode sei interfacial current density [A.m-2]',\n",
" 'Positive electrode sei interfacial current density',\n",
" 'Positive electrode sei interfacial current density [A.m-2]',\n",
" 'X-averaged positive electrode sei interfacial current density',\n",
" 'X-averaged positive electrode sei interfacial current density [A.m-2]',\n",
" 'Inner positive electrode SEI concentration [mol.m-3]',\n",
" 'X-averaged inner positive electrode SEI concentration [mol.m-3]',\n",
" 'Outer positive electrode SEI concentration [mol.m-3]',\n",
" 'X-averaged outer positive electrode SEI concentration [mol.m-3]',\n",
" 'Positive SEI concentration [mol.m-3]',\n",
" 'X-averaged positive electrode SEI concentration [mol.m-3]',\n",
" 'Loss of lithium to positive electrode SEI [mol]',\n",
" 'Inner positive electrode SEI interfacial current density',\n",
" 'Inner positive electrode SEI interfacial current density [A.m-2]',\n",
" 'X-averaged inner positive electrode SEI interfacial current density',\n",
" 'X-averaged inner positive electrode SEI interfacial current density [A.m-2]',\n",
" 'Outer positive electrode SEI interfacial current density',\n",
" 'Outer positive electrode SEI interfacial current density [A.m-2]',\n",
" 'X-averaged outer positive electrode SEI interfacial current density',\n",
" 'X-averaged outer positive electrode SEI interfacial current density [A.m-2]',\n",
" 'Positive electrode SEI interfacial current density',\n",
" 'Positive electrode SEI interfacial current density [A.m-2]',\n",
" 'X-averaged positive electrode SEI interfacial current density',\n",
" 'X-averaged positive electrode SEI interfacial current density [A.m-2]',\n",
" 'Electrolyte tortuosity',\n",
" 'Negative electrolyte tortuosity',\n",
" 'Positive electrolyte tortuosity',\n",
Expand Down Expand Up @@ -483,10 +483,10 @@
" 'X-averaged negative electrode open circuit potential [V]',\n",
" 'Negative electrode entropic change',\n",
" 'X-averaged negative electrode entropic change',\n",
" 'Negative electrode sei film overpotential',\n",
" 'X-averaged negative electrode sei film overpotential',\n",
" 'Negative electrode sei film overpotential [V]',\n",
" 'X-averaged negative electrode sei film overpotential [V]',\n",
" 'Negative electrode SEI film overpotential',\n",
" 'X-averaged negative electrode SEI film overpotential',\n",
" 'Negative electrode SEI film overpotential [V]',\n",
" 'X-averaged negative electrode SEI film overpotential [V]',\n",
" 'Positive electrode interfacial current density',\n",
" 'X-averaged positive electrode interfacial current density',\n",
" 'Positive electrode interfacial current density [A.m-2]',\n",
Expand All @@ -512,10 +512,10 @@
" 'X-averaged positive electrode open circuit potential [V]',\n",
" 'Positive electrode entropic change',\n",
" 'X-averaged positive electrode entropic change',\n",
" 'Positive electrode sei film overpotential',\n",
" 'X-averaged positive electrode sei film overpotential',\n",
" 'Positive electrode sei film overpotential [V]',\n",
" 'X-averaged positive electrode sei film overpotential [V]',\n",
" 'Positive electrode SEI film overpotential',\n",
" 'X-averaged positive electrode SEI film overpotential',\n",
" 'Positive electrode SEI film overpotential [V]',\n",
" 'X-averaged positive electrode SEI film overpotential [V]',\n",
" 'Interfacial current density',\n",
" 'Interfacial current density [A.m-2]',\n",
" 'Interfacial current density per volume [A.m-3]',\n",
Expand Down Expand Up @@ -583,8 +583,8 @@
" 'Measured open circuit voltage [V]',\n",
" 'X-averaged reaction overpotential',\n",
" 'X-averaged reaction overpotential [V]',\n",
" 'X-averaged sei film overpotential',\n",
" 'X-averaged sei film overpotential [V]',\n",
" 'X-averaged SEI film overpotential',\n",
" 'X-averaged SEI film overpotential [V]',\n",
" 'X-averaged solid phase ohmic losses',\n",
" 'X-averaged solid phase ohmic losses [V]',\n",
" 'X-averaged battery open circuit voltage [V]',\n",
Expand Down
Loading