Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed 'Cell capacity [A.h]' to 'Nominal cell capacity [A.h]' #1352

Merged
merged 7 commits into from
Feb 3, 2021
Merged

Renamed 'Cell capacity [A.h]' to 'Nominal cell capacity [A.h]' #1352

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
52b9a91
Renamed 'Cell capacity [A.h]' to 'Nominal cell capacity [A.h]'
Saransh-cpp Feb 2, 2021
81942e3
Added error and deprecation warning related to 'Cell capacity [A.h]'
Saransh-cpp Feb 2, 2021
ca37c59
Updated CHANGELOG.md
Saransh-cpp Feb 2, 2021
9a26c0b
Updated example notebooks, CHANGELOG.md and parameter_values.py with…
Saransh-cpp Feb 2, 2021
7513884
Added Error and warning tests for Cell capacity [A.h] deprecation
Saransh-cpp Feb 3, 2021
04d8d45
Solved the issue 'Deprecated warning not triggered'
Saransh-cpp Feb 3, 2021
df0ab56
Fixed issues with testing deprecation warning of 'Cell capacity'
Saransh-cpp Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
- `Interpolant` now takes `x` and `y` instead of a single `data` entry ([#1312](https://github.com/pybamm-team/PyBaMM/pull/1312))
- Boolean model options ('sei porosity change', 'convection') must now be given in string format ('true' or 'false' instead of True or False) ([#1280](https://github.com/pybamm-team/PyBaMM/pull/1280))
- Operations such as `1*x` and `0+x` now directly return `x`. This can be bypassed by explicitly creating the binary operators, e.g. `pybamm.Multiplication(1, x)` ([#1252](https://github.com/pybamm-team/PyBaMM/pull/1252))
- ```'Cell capacity [A.h]'``` has been renamed to ```'Nominal cell capacity [A.h]'```. ````'Cell capacity [A.h]'``` will be deprecated in the next release. ([#1352](https://github.com/pybamm-team/PyBaMM/pull/1352))
brosaplanella marked this conversation as resolved.
Show resolved Hide resolved

# [v0.3.0](https://github.com/pybamm-team/PyBaMM) - 2020-11-22

Expand Down