#1343 update get_termination_reason to return solution #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinsulzer
approved these changes
Jan 25, 2021
pybamm/solvers/base_solver.py
Outdated
| # to a different event - this isn't captured here (or in the logger info) | ||
| solutions[0], termination = self.get_termination_reason( | ||
| solutions[0], model.events | ||
| ) |
There was a problem hiding this comment.
isn't this a trivial for loop?
There was a problem hiding this comment.
Yeah, I’ll add it. For the logger info shall i just give different info when it’s a list of inputs (ie don’t specify a termination reason since it may be different for each solution).
Codecov Report
@@ Coverage Diff @@
## develop #1344 +/- ##
========================================
Coverage 98.14% 98.14%
========================================
Files 272 272
Lines 15561 15566 +5
========================================
+ Hits 15273 15278 +5
Misses 288 288
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return the solution as well as the termination reason in
get_termination_reason. This is so that the updated solution (solution = solution + event_sol) which includes the event state gets returned by the solver.Fixes #1343
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: