-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce print_citations() in notebooks #1340
Enforce print_citations() in notebooks #1340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
examples/notebooks/Getting Started/Tutorial 1 - How to run a model.ipynb
Show resolved
Hide resolved
examples/notebooks/Getting Started/Tutorial 1 - How to run a model.ipynb
Outdated
Show resolved
Hide resolved
examples/notebooks/Getting Started/Tutorial 2 - Compare models.ipynb
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1340 +/- ##
========================================
Coverage 98.14% 98.14%
========================================
Files 272 272
Lines 15515 15528 +13
========================================
+ Hits 15227 15240 +13
Misses 288 288
Continue to review full report at Codecov.
|
Description
pybamm.print_citations()
has been extended to print formatted citations (both in screen and to files).pybamm.print_citations()
(commented out for the moment).Fixes #1330
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: